Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inference: fix #42090, make sure not to wrap Conditional in PartialStruct #42091

Merged
merged 1 commit into from
Sep 2, 2021
Merged

inference: fix #42090, make sure not to wrap Conditional in PartialStruct #42091

merged 1 commit into from
Sep 2, 2021
+29 −6

Conversation

aviatesk
Copy link
Member

@aviatesk aviatesk commented Sep 2, 2021

No description provided.

@aviatesk aviatesk requested a review from vtjnash September 2, 2021 16:53
@aviatesk aviatesk added backport 1.6 Change should be backported to release-1.6 backport 1.7 compiler:inference Type inference labels Sep 2, 2021
@KristofferC KristofferC mentioned this pull request Sep 2, 2021
Merged
63 tasks
@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Sep 2, 2021
@KristofferC KristofferC merged commit 03e7b23 into master Sep 2, 2021
@KristofferC KristofferC deleted the avi/fix42090 branch September 2, 2021 21:41
KristofferC pushed a commit that referenced this pull request Sep 3, 2021
@aviatesk @KristofferC
inference: fix #42090, make sure not to wrap Conditional in `Partia…
6128dc7 
…lStruct` (#42091)

(cherry picked from commit 03e7b23)
@KristofferC KristofferC mentioned this pull request Sep 3, 2021
Merged
75 tasks
KristofferC pushed a commit that referenced this pull request Sep 3, 2021
@aviatesk @KristofferC
inference: fix #42090, make sure not to wrap Conditional in `Partia…
2389ed1 
…lStruct` (#42091)

(cherry picked from commit 03e7b23)
KristofferC pushed a commit that referenced this pull request Sep 6, 2021
@aviatesk @KristofferC
inference: fix #42090, make sure not to wrap Conditional in `Partia…
9d13e16 
…lStruct` (#42091)

(cherry picked from commit 03e7b23)
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Sep 6, 2021
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Sep 7, 2021
KristofferC pushed a commit that referenced this pull request Sep 8, 2021
@aviatesk @KristofferC
inference: fix #42090, make sure not to wrap Conditional in `Partia…
a3a9182 
…lStruct` (#42091)

(cherry picked from commit 03e7b23)
@aviatesk aviatesk mentioned this pull request Oct 11, 2021
Draft
34 tasks
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
@aviatesk @LilithHafner
inference: fix JuliaLang#42090, make sure not to wrap Conditional i…
cfefebe 
…n `PartialStruct` (JuliaLang#42091)
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@aviatesk @LilithHafner
inference: fix JuliaLang#42090, make sure not to wrap Conditional i…
2343d0f 
…n `PartialStruct` (JuliaLang#42091)
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@aviatesk @staticfloat
inference: fix #42090, make sure not to wrap Conditional in `Partia…
3280a02 
…lStruct` (#42091)

(cherry picked from commit 03e7b23)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

Assignees
No one assigned
Labels
compiler:inference Type inference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aviatesk @vtjnash @KristofferC @DilumAluthge